Skip to content

Temp fix for a crash faced by client using proxy connection #1493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
maratal wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Temp fix for a crash faced by client using proxy connection #1493

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions SocketRocket/SocketRocket/ARTSRWebSocket.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,9 +362,9 @@ - (void)_connectionDoneWithError:(NSError *)error readStream:(NSInputStream *)re
}
// Schedule to run on a work queue, to make sure we don't run this inline and deallocate `self` inside `ARTSRProxyConnect`.
// TODO: (nlutsenko) Find a better structure for this, maybe Bolts Tasks?
dispatch_async(_workQueue, ^{
self->_proxyConnect = nil;
});
// dispatch_async(_workQueue, ^{
// self->_proxyConnect = nil;
// });
}

- (BOOL)_checkHandshake:(CFHTTPMessageRef)httpMessage;
Expand Down