list: Emit per-change forge checks via --cr-checks JSON flag#1268
Open
ed-irl wants to merge 3 commits into
Open
list: Emit per-change forge checks via --cr-checks JSON flag#1268ed-irl wants to merge 3 commits into
ed-irl wants to merge 3 commits into
Conversation
Collaborator
Author
|
This change is part of the following stack:
Change managed by git-spice. |
This was referenced Jun 13, 2026
0f20aae to
c3dab6d
Compare
5bf87ce to
5a56d4c
Compare
Wires the per-change checks data from each forge into 'gs log
--json' so the extension and other tooling can consume rolled-up
state and per-run detail.
- internal/handler/list: new IncludeChecks flag in the request
bitmask; new Checks field on BranchItem; batch-loaded via
Repository.ChecksByChange alongside change state and comment
counts in the existing errgroup.
- log.go: new --cr-checks/spice.log.crChecks flag (negatable,
default false) on commit log / commit log long. Honored by
the JSON presenter; the graph presenter ignores it for now
(UI surface lives in the extension per ext #65).
- JSON schema: change objects gain an optional 'checks' field
with {rollup, runs[], url}, mirroring the spec at ext #100.
Rollup is one of pending/passed/failed/none; runs[] preserves
forge-native state strings.
- testdata/script/log_checks.txt: end-to-end script covering
failed/passed/none rollup states, per-run detail, --no-cr-checks
omission, and the spice.log.crChecks config path.
Tracks irl-llc/git-spice-code-extension#100.
c3dab6d to
7f63525
Compare
6ae625d to
9000eef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wires the per-change checks data from each forge into 'gs log
--json' so the extension and other tooling can consume rolled-up
state and per-run detail.
bitmask; new Checks field on BranchItem; batch-loaded via
Repository.ChecksByChange alongside change state and comment
counts in the existing errgroup.
default false) on commit log / commit log long. Honored by
the JSON presenter; the graph presenter ignores it for now
(UI surface lives in the extension per ext Idea: Local Merge Queue #65).
with {rollup, runs[], url}, mirroring the spec at ext WIP: Revert "restack: Don't use fork point if base hash is up to date" #100.
Rollup is one of pending/passed/failed/none; runs[] preserves
forge-native state strings.
failed/passed/none rollup states, per-run detail, --no-cr-checks
omission, and the spice.log.crChecks config path.
Tracks irl-llc/git-spice-code-extension#100.