Repository navigation
feat: aave agents - #1
Merged
Merged
Conversation
chore: network specific deploy scripts
kyzia551
suggested changes
Dec 5, 2025
kyzia551
left a comment
kyzia551
left a comment
Contributor
There was a problem hiding this comment.
Bettet to add strict updateType check on all agents
Comment on lines
+42
to
+44
| uint256 currentCap = update.updateType.equal('SupplyCapUpdate') | ||
| ? POOL.getConfiguration(update.market).getSupplyCap() | ||
| : POOL.getConfiguration(update.market).getBorrowCap(); |
Contributor
There was a problem hiding this comment.
I would change it to
Suggested change
| uint256 currentCap = update.updateType.equal('SupplyCapUpdate') | |
| ? POOL.getConfiguration(update.market).getSupplyCap() | |
| : POOL.getConfiguration(update.market).getBorrowCap(); | |
| uint256 currentCap = 0; | |
| if(update.updateType.equal('SupplyCapUpdate')) { | |
| currentCap = POOL.getConfiguration(update.market).getSupplyCap(); | |
| } else if(update.updateType.equal('BorrowCapUpdate')) { | |
| currentCap = POOL.getConfiguration(update.market).getBorrowCap(); | |
| } else { | |
| revert WrongUpdateType(update.updateType.); | |
| } |
fix: strict validation of updateType
kyzia551
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the following aave agent contracts to be used by the chaos-agents middleware: