Cache the per-property key node when serializing - #1123
Open
lahma wants to merge 1 commit into
Open
Conversation
Traversing a mapping allocated a throwaway ObjectDescriptor for every property of every object, just to carry the property name as the key scalar. That node is fully determined by the property's immutable name, so cache it per descriptor. ObjectDescriptor is immutable, so behavior is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Serializing a mapping allocated a throwaway
ObjectDescriptorfor every property of every object, purely to carry the property name as the key scalar. That key node is fully determined by the property's (immutable) name, so this caches it per descriptor.ObjectDescriptoris immutable, so behavior is unchanged — all 1979 unit + spec tests pass; builds on net10.0/net8.0/netstandard2.0/netstandard2.1/net47.Same-session A/B (net10.0, DefaultJob, MemoryDiagnoser):
Time is neutral (the dictionary lookup replaces the per-property allocation). Deserialize/parse benchmarks are unchanged with byte-identical allocations. Benchmarks live in #1119.