Skip to content

Improve tests for lexer #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
neiser wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Improve tests for lexer #48

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e735695
parse: refactor test cases for lexer
neiser Feb 9, 2023
5f08da9
parse: remove unneeded state transitions
neiser Feb 9, 2023
4432c75
parse: add test case covering missing closing bracket after default v…
neiser Mar 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions parse/lex.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,10 +246,6 @@ func lexSubstitution(l *lexer) stateFn {
l.subsDepth--
l.emit(itemRightDelim)
return lexText
case r == eof || isEndOfLine(r):
return l.errorf("closing brace expected")
Comment thread
neiser marked this conversation as resolved.
case isAlphaNumeric(r) && strings.HasPrefix(l.input[l.lastPos:], "${"):
fallthrough
case r == '$':
return lexVariable
default:
Expand Down
Loading