Skip to content

fix dragging freezing in firefox #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jefersonbelmiro wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix dragging freezing in firefox #338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69ac35a
fix dragging freezing in firefix 48 ubuntu 16.04
jefersonbelmiro Sep 21, 2016
5cc5708
update dist files
jefersonbelmiro Sep 27, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions dist/ng-sortable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,6 +621,7 @@
unBindEvents,//unbind the drag events.
hasTouch,// has touch support.
isIOS,// is iOS device.
isIE,// is MS browser.
longTouchStart, // long touch start event
longTouchCancel, // cancel long touch
longTouchTimer, // timer promise for the long touch on iOS devices
Expand All @@ -633,6 +634,7 @@

hasTouch = 'ontouchstart' in $window;
isIOS = /iPad|iPhone|iPod/.test($window.navigator.userAgent) && !$window.MSStream;
isIE = /MSIE|Trident\/|Edge\//.test($window.navigator.userAgent);

if (sortableConfig.handleClass) {
element.addClass(sortableConfig.handleClass);
Expand Down Expand Up @@ -900,9 +902,15 @@
targetY = eventObj.pageY - ($window.pageYOffset || $document[0].documentElement.scrollTop);

//IE fixes: hide show element, call element from point twice to return pick correct element.
dragElement.addClass(sortableConfig.hiddenClass);
if (isIE) {
dragElement.addClass(sortableConfig.hiddenClass);
}

targetElement = angular.element($document[0].elementFromPoint(targetX, targetY));
dragElement.removeClass(sortableConfig.hiddenClass);

if (isIE) {
dragElement.removeClass(sortableConfig.hiddenClass);
}

$helper.movePosition(eventObj, dragElement, itemPosition, containment, containerPositioning, scrollableContainer);

Expand Down
Loading