Repository navigation
fix: resolve bare create paths and command routing in the type-column… - #16
Merged
Merged
Conversation
… view
Unity's built-in creates hand BeginPreimportedNameEditing a bare file
name ("New Folder", "NewBehaviourScript.cs"); the resolution to a full
project path lives in CreateAssetUtility.BeginNewAssetCreation - inside
the very call the Harmony prefix skips. The captured request therefore
fell into the column view's folder-mismatch guard and every built-in
create was silently cancelled: no phantom, no rename, no asset. Mirror
the skipped resolution in the prefix, against the active tab's folder.
The create-request debounce is now scoped to the PollBrowserCreate
fallback only: preimported creates all arrive with the same constant
instance id and default path, so the debounce also swallowed legitimate
repeat creates after a rename or cancel.
While the column view covers the list area, the browser's folder tree
keeps keyboard focus forever (the list's focus-claiming click never
runs), so ProjectBrowser routed Duplicate/Delete/Cut/Copy/Paste to the
tree selection - duplicating or deleting the shown folder instead of
the selected assets. Claim keyboard focus on column-view clicks, as the
stock list would, and drop the tree's focus when such a command arrives
while the selection is visible in the view, so the browser's generic
Selection-based handler acts instead.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
tabstep | d504e7c | Jul 14 2026, 01:07 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… view
Unity's built-in creates hand BeginPreimportedNameEditing a bare file name ("New Folder", "NewBehaviourScript.cs"); the resolution to a full project path lives in CreateAssetUtility.BeginNewAssetCreation - inside the very call the Harmony prefix skips. The captured request therefore fell into the column view's folder-mismatch guard and every built-in create was silently cancelled: no phantom, no rename, no asset. Mirror the skipped resolution in the prefix, against the active tab's folder.
The create-request debounce is now scoped to the PollBrowserCreate fallback only: preimported creates all arrive with the same constant instance id and default path, so the debounce also swallowed legitimate repeat creates after a rename or cancel.
While the column view covers the list area, the browser's folder tree keeps keyboard focus forever (the list's focus-claiming click never runs), so ProjectBrowser routed Duplicate/Delete/Cut/Copy/Paste to the tree selection - duplicating or deleting the shown folder instead of the selected assets. Claim keyboard focus on column-view clicks, as the stock list would, and drop the tree's focus when such a command arrives while the selection is visible in the view, so the browser's generic Selection-based handler acts instead.