Skip to content

a connection without peer info should be rejected (#300) #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HerrMuellerluedenscheid merged 2 commits into from
Jan 6, 2026
Merged

a connection without peer info should be rejected (#300) #304

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5fe2e51
if peer info is not available, return None (#300)
ajmirsky Dec 8, 2025
46b9e57
in python 3.10, streamwriter doesn't close when it's gc, need to expl…
ajmirsky Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion amqtt/adapters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,8 +176,10 @@ async def drain(self) -> None:
if not self.is_closed:
await self._writer.drain()

def get_peer_info(self) -> tuple[str, int]:
def get_peer_info(self) -> tuple[str, int] | None:
extra_info = self._writer.get_extra_info("peername")
if not extra_info or len(extra_info) < 2:
return None
return extra_info[0], extra_info[1]

def get_ssl_info(self) -> ssl.SSLObject | None:
Expand Down
11 changes: 11 additions & 0 deletions tests/test_broker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1028,3 +1028,14 @@ async def test_broker_with_absent_auth_plugin_filter():
await mqtt_client.connect()

await broker.shutdown()


@pytest.mark.asyncio
async def test_client_without_peer_info(broker, mock_plugin_manager):
client = MQTTClient(config={'auto_reconnect':False})

# if the broker's stream writer for this client does not have peer info, the client should fail to connect
with patch.object(asyncio.streams.StreamWriter, 'get_extra_info', return_value=None) as mock_extra_info:
with pytest.raises(ConnectError):
await client.connect("mqtt://127.0.0.1/")
await asyncio.sleep(0.01)
Copy link
Copy Markdown
Contributor

@HerrMuellerluedenscheid HerrMuellerluedenscheid Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests fail with timeout. I'm wondering if the rather short sleep could be one reason?

Copy link
Copy Markdown
Collaborator Author

@ajmirsky ajmirsky Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

appreciate the suggestion!

didn't get a chance to debug yesterday, should have a fix later today

Copy link
Copy Markdown
Collaborator Author

@ajmirsky ajmirsky Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HerrMuellerluedenscheid can you review when you get a chance?

Loading