refactor(eth/downloader): truncate peer id in sync logs - #2510
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Will this change conflict with current Eth implementation? |
the change is same with geth and better than geth: |
Align with upstream go-ethereum: tag sync logs with the peer id truncated to 16 chars. The truncation lives in a peerLogger helper so RegisterPeer, UnregisterPeer and DeliverHeaders share one implementation, and the redundant "peer" key is dropped from the individual header delivery lines.
96e84cd to
8b70682
Compare
Proposed changes
Align with upstream go-ethereum: tag sync logs with the peer id truncated to 16 chars. The truncation lives in a peerLogger helper so RegisterPeer, UnregisterPeer and DeliverHeaders share one implementation, and the redundant "peer" key is dropped from the individual header delivery lines.
Ref: ethereum#21482
Types of changes
What types of changes does your code introduce to XDC network?
Put an
✅in the boxes that applyImpacted Components
Which parts of the codebase does this PR touch?
Put an
✅in the boxes that applyChecklist
Put an
✅in the boxes once you have confirmed below actions (or provide reasons on not doing so) that