Config: support abstract unix sockets in remote loader#6111
Open
kastov wants to merge 1 commit into
Open
Conversation
…tions for HTTP/Unix socket URL parsing - Replaced custom URL parsing and socket resolution logic in `webhook.go` with utility functions from `utils`. - Updated `ConfigLoader` in `external.go` to handle deprecated `http+unix://` prefix and streamline HTTP content fetching.
Collaborator
|
sock 就可以设目录权限了，比以前看起来安全得多虽然我不用 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial PR (#5200) lacks support for abstract unix sockets.
This PR unifies the http config loader to share the same target format as the webhook notifier. Adds @ / @@ abstract socket support.
Supported forms:
http(s)://host/api/path/to/socket.sock[:/api]@abstract[:/api]@@padded[:/api]http+unix://is marked as deprecated — still works (prints a warning, internally rewritten to the new form), but the direct forms are preferred.Shared helpers
ResolveSocketPathandSplitHTTPUnixURLextracted tocommon/utils/unixsocket.go