Burst observatory: Fix interval validation, race conditions, and untested-slot sentinel#6106
Open
Jolymmiles wants to merge 3 commits into
Open
Burst observatory: Fix interval validation, race conditions, and untested-slot sentinel#6106Jolymmiles wants to merge 3 commits into
Jolymmiles wants to merge 3 commits into
Conversation
Contributor
Jolymmiles
commented
May 10, 2026
Jolymmiles
commented
- Compare Interval to 10s
- Serialize check rounds
- Cancel pending pings on StopScheduler
…sted-slot sentinel - Compare Interval to 10s (was bare 10ns); old check almost never fired - Serialize check rounds via runMu so initial and scheduled doCheck no longer overlap - Cancel pending pings on StopScheduler via runCtx + WaitGroup; replaces leaky time.AfterFunc - Use rttUntested sentinel for unfilled buffer slots instead of magic zero
Contributor
Author
|
i think we should rerun checks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.