[WIP] Fix navigation bar to display all entries correctly#1935
Merged
Conversation
Remove parent-walking logic in FindMemberAtRow that was causing the navigation bar to stop following the cursor after the last entity's declared range. Now returns the last entity directly instead of walking up to its outermost parent, allowing proper cursor tracking throughout the file. Agent-Logs-Url: https://github.com/X-Sharp/XSharpPublic/sessions/6e1ccee3-17db-4c9b-9236-7a3ed85c8f68 Co-authored-by: RobertvanderHulst <14240939+RobertvanderHulst@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses navigation bar cursor tracking by preventing XFile lookup helpers from walking from the last entity back up to a parent entity when the cursor is past the last entity’s range.
Changes:
- Updated
FindMemberAtRowto return the last entity directly for lines past the final entity. - Updated
FindMemberAtPositionsimilarly for positions past the final entity.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.