Fix: Undefined index 'extension' when attachment URL has no file extension - #262
Open
2501030204-star wants to merge 1 commit into
Open
Fix: Undefined index 'extension' when attachment URL has no file extension#2622501030204-star wants to merge 1 commit into
2501030204-star wants to merge 1 commit into
Conversation
…pathinfo() is called on a URL without a file extension, the 'extension' key is absent from the returned array, causing an undefined index notice. Added isset() guards on both \$parts['extension'] and \$parts_new['extension'] in the URL remapping block. fixes WordPress#139
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #139
When
pathinfo()is called on an attachment URL that has no file extension(e.g.
https://example.com/files/myfile), theextensionkey is absentfrom the returned array, causing:
Notice: Undefined index: extension in class-wp-import.php on line 1043Changes
Added
isset()guards on both$parts['extension']and$parts_new['extension']in the URL remapping block. Falls back to the full basename when no extension
is present, preserving existing behaviour for normal URLs.