Skip to content

added filter to control whether authcode autosubmits #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eric-michel wants to merge 8 commits into
base: master
Choose a base branch
from
Open

added filter to control whether authcode autosubmits #741

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
808cd6a
added filter to control whether authcode autosubmits
eric-michel Dec 18, 2025
00605f2
updated readme
eric-michel Dec 23, 2025
bd499ec
swapped variable output to data attribute on form and check happens w…
eric-michel Jan 9, 2026
5acf913
Merge branch 'master' into auto-submit-hook
masteradhoc Feb 25, 2026
aac5403
add provider_key
masteradhoc Mar 2, 2026
628a461
filter documentation added
eric-michel Mar 3, 2026
da121df
Merge branch 'WordPress:master' into auto-submit-hook
eric-michel Mar 3, 2026
749a8f0
shifted auto-submit check to data-digits attribute
eric-michel Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions class-two-factor-core.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -958,6 +958,7 @@ public static function login_html( $user, $login_nonce, $redirect_to, $error_msg
$interim_login = isset( $_REQUEST['interim-login'] ); // phpcs:ignore WordPress.Security.NonceVerification.Recommended

$rememberme = intval( self::rememberme() );
Comment thread
eric-michel marked this conversation as resolved.
$auto_submit_authcode = apply_filters( 'two_factor_auto_submit_authcode', true );
Comment thread
masteradhoc marked this conversation as resolved.
Outdated

if ( ! function_exists( 'login_header' ) ) {
// We really should migrate login_header() out of `wp-login.php` so it can be called from an includes file.
Expand Down Expand Up @@ -1076,13 +1077,15 @@ function() {

this.value = value;

// Auto-submit if it's the expected length.
if ( expectedLength && value.replace( / /g, '' ).length == expectedLength ) {
if ( undefined !== form.requestSubmit ) {
form.requestSubmit();
form.submit.disabled = "disabled";
<?php if ( $auto_submit_authcode ) { ?>
Copy link
Copy Markdown
Collaborator

@kasparsd kasparsd Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use the variable state to generate a JS variable instead? That would allow us to eventually move this JS into an external file and pass that as data to the script.

Something like const autoSubmitEnabled = <?php echo json_encode( ... ); ?> and then use that here in pure JS if-check?

Copy link
Copy Markdown
Contributor Author

@eric-michel eric-michel Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to make this change! How/where would you like the JS variable to be output? I could output it as a data attribute on the form element (something like data-auto-submit) or could output it as a small <script> snippet in the <head> tag so it's a global variable that can be accessed. I kind of lean toward the data attribute to keep it scoped to the form itself.

Copy link
Copy Markdown
Member

@jeffpaul jeffpaul Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kasparsd any thoughts on the question above on approach?

Copy link
Copy Markdown
Contributor Author

@eric-michel eric-michel Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kasparsd @jeffpaul I opted to add a data attribute on the form and check for that in the JS if statement. Seems pretty clean to me. Take a look and let me know what you think!

// Auto-submit if it's the expected length.
if ( expectedLength && value.replace( / /g, '' ).length == expectedLength ) {
if ( undefined !== form.requestSubmit ) {
form.requestSubmit();
form.submit.disabled = "disabled";
}
}
}
<?php } ?>
}
);
}
Expand Down