Skip to content

Pattern directory: Validate the fields the directory renders #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
obenland merged 2 commits into from
Sep 4, 2026
+32 −9
Merged

Pattern directory: Validate the fields the directory renders #769

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f312822
Pattern directory: Validate the fields the directory renders
obenland Sep 4, 2026
a696f7d
Pattern directory: Name the whole pattern in the directive error
obenland Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 20 additions & 9 deletions public_html/wp-content/plugins/pattern-directory/includes/pattern-validation.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,16 +398,19 @@ function validate_block_directives( $prepared_post, $request ) {
return $prepared_post;
}

if ( ! isset( $prepared_post->post_content ) ) {
return $prepared_post;
}
// Every field the directory renders, not just the one the pattern editor writes.
foreach ( array( 'post_content', 'post_title', 'post_excerpt' ) as $field ) {
if ( ! isset( $prepared_post->$field ) ) {
continue;
}

if ( content_has_block_directives( $prepared_post->post_content ) ) {
return new \WP_Error(
'rest_pattern_interactivity_directive',
__( 'Pattern content contains interactivity directives, which are not allowed.', 'wporg-patterns' ),
array( 'status' => 400 )
);
if ( content_has_block_directives( $prepared_post->$field ) ) {
return new \WP_Error(
'rest_pattern_interactivity_directive',
__( 'Pattern content contains interactivity directives, which are not allowed.', 'wporg-patterns' ),
array( 'status' => 400 )
Comment thread
obenland marked this conversation as resolved.
);
Comment thread
obenland marked this conversation as resolved.
}
}

return $prepared_post;
Expand Down Expand Up @@ -841,6 +844,14 @@ function check_for_spam( $post ) {
* @return boolean
*/
function is_title_valid( $title ) {
if ( strip_shortcodes( $title ) !== $title || wp_strip_all_tags( $title ) !== $title ) {
return false;
}

if ( content_has_block_directives( $title ) ) {
return false;
}
Comment thread
obenland marked this conversation as resolved.

// Check title against a list of disallowed words.
// Note the space after `test ` to avoid matching "testimonial".
$disallow_list = array( 'test ', 'testing', 'my pattern', 'wordpress', 'example' );
Expand Down