Fix native app windows restoring the wrong saved instance - #763
Open
nickhamze wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
OpenStation apps can keep multiple windows open at once. That is essential for apps such as Fleet, where each window may represent a different WordPress site.
After a desktop reload, OpenStation restored the first native app window but could lose additional instances. The unused saved state could then be picked up by a newly opened window, making that window show the previous saved destination instead of the site the user selected. The reproduction did not send remote content writes, but destination identity must be reliable before multi-site management is safe to launch.
What changed
There are no new REST endpoints, authentication changes, database migrations, or plugin-facing setup steps.
User-visible result
Before: site A returned, site B disappeared, and opening site C could reopen B under the reused second-window ID.
After: site A returns as
fleet-site, site B returns asfleet-site-2, and site C opens independently asfleet-site-3.Verification
The Fleet regression used only local disposable fixtures and made no remote content writes.