feat(window): add minimize and restore dock animations. - #760
Open
KarunyaChavan wants to merge 7 commits into
Open
feat(window): add minimize and restore dock animations.#760KarunyaChavan wants to merge 7 commits into
KarunyaChavan wants to merge 7 commits into
Conversation
- Implement WAAPI-driven scale-and-translate minimize flight targeting the owner dock tile - Implement symmetrical reverse restore flight from dock icon back to window rect - Ensure .os-window--minimized suppresses base transitions to prevent post-animation visual bounce/maximize flash - Add `osWindowBaseId` dataset attribute to dock tiles for reliable icon target resolution
- Extract `_clearGenieStyles`, `_cancelGenieAnimation`, `_buildGenieTransform`, and `_canGenieAnimate` helpers. - Eliminate duplicate cancel/cleanup boilerplate across `minimize()`, `restore()`, and `destroy()`. - Unify the geometry math for WAAPI keyframes.
…plugin tiles `openPage()` only called `windowManager.focus()` for windowId-only tiles (shortcut icons promoted to dock, plugin-registered windows), which reorders the z-stack but never unminimizes the window.
Collaborator
|
Wow! Is looking great! I would personally add a more vanish towards the end of the minimize animation, what do you think? |
Collaborator
|
@KarunyaChavan I've asked the same to another top contributor: would you like to create a guest-post in our blog as one of the tops contributors? :) You can write about yourself, who are you, why you like OpenStation, why you contribute, the tools you use, etc. |
- Test WAAPI animation trigger and modifier classes during minimize/restore flights - Verify prefers-reduced-motion bypasses the flight animation directly to minimized state
KarunyaChavan
marked this pull request as ready for review
September 4, 2026 13:06
Contributor
Author
|
I’ve added a fade-out at the end of the flight animation when the window is minimized, creating a vanishing effect. I’ve also adjusted the animation duration so it doesn’t feel too quick.
Sure, it would be my pleasure. Thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a "genie" animation for minimizing and restoring windows, replacing the old fade effect. Windows now visually shrink and fly directly into their corresponding dock icon, and grow back out from the dock when restored.
Closes #759
visual_demo.mov
Why?
What Changed?
src/window/index.ts:_buildGenieTransform,_cancelGenieAnimation,_clearGenieStyles) to keep the implementation DRY across theminimize,restore, anddestroylifecycles.assets/css/window-states.css:src/dock.ts: Existing Bug Fix:windowId-only tiles was only callingfocus(), which reordered the z-stack but never unminimized the window. We now correctly check the state and callrestore()if the window was minimized.