Skip to content

Parse the content of inline HTML comments #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Witiko merged 4 commits into from
Apr 7, 2026
Merged

Parse the content of inline HTML comments #642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
598c5be
Add `tests/testfiles/regression/github/issue-641.test`
Witiko Apr 2, 2026
6c4efa4
Merge branch 'main' into fix/inline-html-comment-renderer
Witiko Apr 7, 2026
fb09781
Parse inline HTML comments
Witiko Apr 7, 2026
5fe1f96
Update `CHANGES.md`
Witiko Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Changes

## 3.15.0 (2026-03-XX)
## 3.15.0 (2026-04-XX)

### Development

Expand All @@ -18,6 +18,7 @@ This version of the Markdown package has fixed the following issues:
- Strip leading and trailing spaces for `inlineHtmlComment` renderers. (#635)
- Specify `.value_required:n = { true }` for all options that require values.
(discovered by @michal-h21 in #615, fixed in #640)
- Parse the content of inline HTML comments. (described in #641, fixed in #642)

### Continuous integration

Expand Down
8 changes: 4 additions & 4 deletions markdown.dtx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32155,8 +32155,7 @@ parsers.html_comment

parsers.html_inline_comment = (parsers.html_comment_start / "")
* -P(">") * -P("->")
* Cs(( V("NoSoftLineBreakEndline")
+ parsers.any
* Cs(( parsers.any
- parsers.nested_breaking_blank
- parsers.html_comment_end)^0)
* (parsers.html_comment_end / "")
Expand Down Expand Up @@ -32357,8 +32356,7 @@ parsers.html_any_block = parsers.html_any_block_opening

parsers.html_inline_comment_full = parsers.html_comment_start
* -P(">") * -P("->")
* Cs(( V("NoSoftLineBreakEndline")
+ parsers.any - P("--")
* Cs(( parsers.any - P("--")
- parsers.nested_breaking_blank
- parsers.html_comment_end)^0)
* parsers.html_comment_end
Expand Down Expand Up @@ -34283,6 +34281,7 @@ end
if options.htmlOutput == "commonmark" then
parsers.InlineHtml
= Cs(parsers.html_inline_comment)
/ self.parser_functions.parse_inlines_no_html
/ writer.inline_html_comment
+ Cs(parsers.html_any_empty_inline_tag)
/ writer.inline_html_empty_tag
Expand All @@ -34298,6 +34297,7 @@ end
/ writer.inline_html_close_tag
else
parsers.InlineHtml = Cs(parsers.html_inline_comment)
/ self.parser_functions.parse_inlines_no_html
/ writer.inline_html_comment
+ Cs( parsers.html_any_empty_inline_tag
+ parsers.html_inline_instruction
Expand Down
7 changes: 7 additions & 0 deletions tests/testfiles/regression/github/issue-641.test
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<<<
foo <!-- bar
_baz_ -->
>>>
BEGIN document
inlineHtmlComment: bar(softLineBreak)(emphasis: baz)
END document
Loading