Repository navigation
Extend destination canvas when copying image differences - #42
Merged
Merged
Conversation
…ference. Update scrollbars after copying.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Canvas extension can bypass ghost-line rejection and overwrite pixels in the wrong destination row or column.
1 open issue
What changed in this PR
Updates image-difference copying to populate expanded destination regions and refresh scrollbars afterward.
Changes:
- Allows copying beyond the destination’s previous bounds.
- Updates scrollbars after single, all, and three-way difference copies.
| File | Description |
|---|---|
| src/WinIMergeLib/ImgMergeWindow.hpp | Refreshes scrollbars after copying differences. |
| src/WinIMergeLib/ImgMergeBuffer.hpp | Allows writes into expanded destination regions. |
Review effort: Balanced
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expand the destination image as needed and copy the full selected difference. Update scrollbars after copying.