-
Notifications
You must be signed in to change notification settings - Fork 110
Filter blank failedWhere Queries from mutator #1482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
agusaldasoro
wants to merge
8
commits into
master
Choose a base branch
from
agusaldasoro-patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+173
−1
Open
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
7e195b0
Filter blank failedWhere Queries from mutator
agusaldasoro e57e3cc
Merge branch 'master' into agusaldasoro-patch-1
agusaldasoro a812193
Merge branch 'master' into agusaldasoro-patch-1
agusaldasoro 0637537
Add tests
agusaldasoro b5f0ffa
Move the fix to the correct function
agusaldasoro 2608797
Merge branch 'master' into agusaldasoro-patch-1
agusaldasoro 29d7fe7
Add integration test
agusaldasoro 27e24db
Merge branch 'master' into agusaldasoro-patch-1
agusaldasoro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -277,6 +277,7 @@ abstract class ApiWsStructureMutator : StructureMutator() { | |
| val oldSqlActions = mutableListOf<EnvironmentAction>().plus(ind.seeInitializingActions()) | ||
|
|
||
| val failedWhereQueries = evaluatedIndividual.fitness.getViewOfAggregatedFailedWhereQueries() | ||
| .filter { it.isNotBlank() } | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hey! You are right, I moved the fix to that function |
||
| val addedSqlInsertions = handleFailedWhereSQL(ind, fw, failedWhereQueries, mutatedGenes, sampler) | ||
|
|
||
| ind.repairInitializationActions(randomness) | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Uh oh!
There was an error while loading. Please reload this page.