Fix/con 542 protocol hash comparison edits - #880
Open
tw2113 wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handles
https://app.clickup.com/t/9011385391/CON-542
Description
This PR removes the protocol from our connection status hashes to help avoid differences from
httpvshttps. We'll just store the hostname.This PR also updates our
updatesclass' usage of version compare to not have things run when the versions match.Lastly, it utilizes our
updatesclass to delete our previous stored hash used for domain differences, so that it doesn't try to compare protocol'd version. It handles the releases that have the option included, so before 2.19.0 isn't affected.