add bin modified date and keep it updated#509
Open
mike-kaimika wants to merge 2 commits intomasterfrom
Open
Conversation
mike-kaimika
force-pushed
the
add_bin_modified_date
branch
from
a0aae45 to
1e4dde8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new modified date to the bin model. It also handles keeping that value updated with extra logic where needed. Most places will call
.save()on the bin and that will keep it updated, but the value must be manually updated when the bin is updated as a side effect of another action. For example, adding comments, adding/removing tags, etc