nvim oxlint#23
Conversation
📝 WalkthroughWalkthroughAdds a new ChangesNeovim JS/TS Tooling Overhaul
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@nvim/.config/nvim/after/plugin/none-ls.lua`:
- Around line 7-16: The eslint_config_files table is missing common ESLint
configuration filename variants, which prevents eslint_d from loading in
projects using those config formats. Add the missing common ESLint configuration
filename variants to the eslint_config_files table, including YAML format
variants such as .eslintrc.yaml and .eslintrc.yml to ensure the conditional
registration check at line 31 can properly detect all standard ESLint
configuration file formats.
In `@nvim/.config/nvim/lua/greg/vite_plus.lua`:
- Around line 33-40: The vite_config file detection logic only checks for
`vite.config.ts` but misses projects using `vite.config.mts`. Update the code
block starting with the vite_config variable assignment to also check for
`vite.config.mts` in addition to `vite.config.ts`. Add logic to scan both file
extensions for the "vite-plus" content, ensuring that projects using either
configuration file format are correctly identified as Vite+ projects.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 2bdf5ecd-edea-4e82-bb3b-dfe05c662c8f
📒 Files selected for processing (8)
claude/.claude/settings.jsonnvim/.config/nvim/after/plugin/conform.luanvim/.config/nvim/after/plugin/none-ls.luanvim/.config/nvim/after/plugin/oxc.luanvim/.config/nvim/lua/greg/pack.luanvim/.config/nvim/lua/greg/vite_plus.luanvim/.config/nvim/nvim-pack-lock.jsonscripts/brews.sh
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/brews.sh`:
- Line 193: The `fnm default lts-latest` command in the JavaScript packages
installation block within the `prompt_and_install_shell` function call is
invalid because `fnm default` requires an explicit version number, not
`lts-latest`. After running `fnm install --lts`, extract the installed version
using `fnm list` and pass the result explicitly to `fnm default`. You can use
command substitution to get the installed version (for example, by filtering the
list output and selecting the first matching version) and pass it to `fnm
default` instead of the literal `lts-latest` string.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 1b9236ba-fa24-4120-a845-a6d5861198b5
📒 Files selected for processing (5)
nvim/.config/nvim/after/plugin/conform.luanvim/.config/nvim/after/plugin/none-ls.luanvim/.config/nvim/lua/greg/vite_plus.luascripts/brews.shscripts/pacs.sh
🚧 Files skipped from review as they are similar to previous changes (3)
- nvim/.config/nvim/lua/greg/vite_plus.lua
- nvim/.config/nvim/after/plugin/none-ls.lua
- nvim/.config/nvim/after/plugin/conform.lua
| # JavaScript/Node.js developement. | ||
| install_javascript_packages() { | ||
| prompt_and_install_shell "JavaScript packages" 'brew install fnm oven-sh/bun/bun pnpm fsouza/prettierd/prettierd && fnm install 22 && npm install -g eslint_d typescript-language-server typescript' | ||
| prompt_and_install_shell "JavaScript packages" 'brew install fnm oven-sh/bun/bun pnpm && fnm install --lts && fnm default lts-latest && eval "$(fnm env)" && npm install -g @fsouza/prettierd eslint_d@15 typescript-language-server typescript' |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
In current fnm releases, is fnm default lts-latesta supported way to set the default Node.js version to latest LTS? If not, what is the recommended command sequence afterfnm install --lts?
💡 Result:
No, fnm default lts-latest is not a supported command for setting the default Node.js version [1]. The fnm default command expects a specific version number (e.g., 20 or 22.13.1) to set as the global default [2][3][4]. To set the default Node.js version to the latest LTS after installing it, you should follow this sequence: 1. Install the latest LTS version: fnm install --lts 2. Identify the specific version that was just installed: fnm list 3. Set that specific version as the default: fnm default <VERSION_NUMBER> (Replace <VERSION_NUMBER> with the version identified in step 2, such as 22.13.1.) The fnm default command functions as a shorthand for creating an alias named default [5][2]. Because lts-latest is not a resolvable version string within the fnm default command's logic, attempting to use it will result in an error [1].
Citations:
- 1: alias: can not default to lts-latest Schniz/fnm#1203
- 2: https://github.com/Schniz/fnm/blob/master/docs/commands.md
- 3: https://www.fnmnode.com/commands/
- 4: https://dev.to/astrobotme/mastering-nodejs-version-management-with-fast-node-manager-fnm-17ji
- 5: https://docs.rs/crate/fnm/latest/source/docs/commands.md
Fix fnm default lts-latest on line 193 — this command is unsupported and will fail.
The fnm default command requires an explicit version number (e.g., 20 or 22.13.1), not lts-latest. After fnm install --lts, you must identify the installed version and set it explicitly. Replace:
fnm install --lts && fnm default lts-latest && eval "$(fnm env)"
with:
fnm install --lts && fnm default "$(fnm list | grep -v default | head -1)" && eval "$(fnm env)"
Or better, assign to a variable first to ensure clarity and robustness.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@scripts/brews.sh` at line 193, The `fnm default lts-latest` command in the
JavaScript packages installation block within the `prompt_and_install_shell`
function call is invalid because `fnm default` requires an explicit version
number, not `lts-latest`. After running `fnm install --lts`, extract the
installed version using `fnm list` and pass the result explicitly to `fnm
default`. You can use command substitution to get the installed version (for
example, by filtering the list output and selecting the first matching version)
and pass it to `fnm default` instead of the literal `lts-latest` string.
1 participant
Summary by CodeRabbit