[PLAT-8122] remove obsolete deps on uuid & is-plain-object#770
Merged
[PLAT-8122] remove obsolete deps on uuid & is-plain-object#770
Conversation
|
aeischeid
commented
May 5, 2026
|
|
||
| export function create(): UUID { | ||
| return uuid(); | ||
| return globalThis.crypto.randomUUID(); // synonomys with uuid.v4() |
Contributor
Author
There was a problem hiding this comment.
https://developer.mozilla.org/en-US/docs/Web/API/Crypto/randomUUID
browser and node env support is solid, so compatibility shouldn't be an issue, but jsDom is an outlier, new versions of jest could help that, or vitest + happy-dom which is what newer versions of lerna guide towards
amvertex
reviewed
May 5, 2026
| }, | ||
| "dependencies": { | ||
| "fast-deep-equal": "^3.1.3", | ||
| "is-plain-object": "^3.0.0", |
Contributor
There was a problem hiding this comment.
Nice to remove some dependencies!
amvertex
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleanup of obsolete dependencies
Test Plan
Automated unit tests should cover this pretty well, but will also get incidental coverage in manual and integration testing for 1.0 release
Release Notes
Some packages that got type info from @types/uuid could just use
: stringif you just need to get the job done and don't care about strict enforcement, or use${string}-${string}-${string}-${string}-${string}if you want a bit morePossible Regressions
Shouldn't be
Dependencies
Build off of #763