Skip to content

[PLAT-8122] React19, Stencil4, & other framework tooling upgrades #763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aeischeid merged 49 commits into from
May 4, 2026
Merged

[PLAT-8122] React19, Stencil4, & other framework tooling upgrades #763

Show file tree
Hide file tree
Changes from 33 commits
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
8587feb
prep for yarn 4 in gitignore
aeischeid Apr 27, 2026
48b1ecb
basic version bump and config changes for stencil4, TS 5, & React19
aeischeid Apr 27, 2026
3b17207
formating or prettier type changes
aeischeid Apr 28, 2026
5850586
TS tightening & stencil upgrade specific changes
aeischeid Apr 28, 2026
f824a25
muted console.debug in jest setup
aeischeid Apr 28, 2026
e179ee1
fix missing hasGeometry attr
aeischeid Apr 28, 2026
9924829
remove @aee getMarkupElement from viewr-markup
aeischeid Apr 28, 2026
a3f9a32
Moxks and type tightening around png-decoder
aeischeid Apr 28, 2026
cfea7c6
clearLoadingTimer and terminate on webWorker mock
aeischeid Apr 28, 2026
45c10d2
runInBand for jest limit concurancy for stencil
aeischeid Apr 28, 2026
3f6860e
fix png-decoder import issue
aeischeid Apr 28, 2026
8e4072c
update stencil config for new TS plugin
aeischeid Apr 28, 2026
afa7ca8
Merge branch 'master' into newReact19Stencil4
aeischeid Apr 28, 2026
dd52889
Update yarn.lock
aeischeid Apr 28, 2026
a527d05
Update rollup.config to pass inlineDynamicImports: true
aeischeid Apr 28, 2026
59f27b4
Merge branch 'master' into newReact19Stencil4
aeischeid Apr 29, 2026
a21f413
revert doc-viewer packages to private for now
aeischeid Apr 29, 2026
8b0939b
add back working version of `@see` for viewer documentation
aeischeid Apr 29, 2026
14d94b3
add stencilPackageName for reactOutputTarget in viewer
aeischeid Apr 29, 2026
81803f2
update interval type to NodeJS.Timeout per feedback
aeischeid Apr 29, 2026
691e1af
add some readonly specifiers per sonarQube suggestions
aeischeid Apr 29, 2026
1a7586c
remove applyPolyfills from the viewer-vue too
aeischeid Apr 29, 2026
56ba9c1
remove obsolete requestidlecallback polyfill
aeischeid Apr 29, 2026
f7afa72
new lock file after removing polyfill
aeischeid Apr 29, 2026
72c5511
react-output-target needs to be a runtime dep of react packages, but
aeischeid Apr 29, 2026
712fa0b
bump stream-api to ts 5 too, last one
aeischeid Apr 29, 2026
c78e14b
attempt better SSR case for viewer-react
aeischeid Apr 29, 2026
a52ffd4
Revert "attempt better SSR case for viewer-react"
aeischeid Apr 30, 2026
7bda5d3
defensive wrappers around window object to avoid SSR issues
aeischeid Apr 29, 2026
46f1a5a
basic test for SSR safety / via node import try
aeischeid Apr 30, 2026
e29999f
make builder and viewer-react module first bundles
aeischeid Apr 30, 2026
e8313d3
big push to move builds to type:module
aeischeid May 1, 2026
2d301bf
fix postbuild script - which exists to maintain backwards compat with
aeischeid May 1, 2026
867de4d
Potential fix for pull request finding in formate-example.js
aeischeid May 1, 2026
466bab6
more backwards compatible exports map for viewer
aeischeid May 1, 2026
55bb5ef
address sonar complaints in short term way so i can test builds
aeischeid May 1, 2026
6cb4499
use explict prettier deb more directly
aeischeid May 1, 2026
7e92766
minor update to lockfile for prettier
aeischeid May 1, 2026
b8c96b1
Merge branch 'master' into newReact19Stencil4
aeischeid May 1, 2026
9e26ec1
remove nomodule fallbacks in examples that pointed to artifacts that
aeischeid May 1, 2026
b446dfa
have doc-viewer exports/bundles match viewer
aeischeid May 1, 2026
d181168
will do withouth html comment lines and have examples in readme instead
aeischeid May 1, 2026
2ae52f1
had to rename lint config files after changing to type module in
aeischeid May 1, 2026
8bcc23b
Merge branch 'master' into newReact19Stencil4
aeischeid May 1, 2026
3a394f9
new yarn.lock after merge main
aeischeid May 1, 2026
525b825
Merge branch 'master' into newReact19Stencil4
aeischeid May 4, 2026
76857ad
fix botched conflict resolve done via GH ui
aeischeid May 4, 2026
4235cf0
fix another unresolved merge
aeischeid May 4, 2026
72d3efd
newly generated lock
aeischeid May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ jspm_packages/

# Yarn Integrity file
.yarn-integrity
.yarn/install-state.gz

# dotenv environment variables file
.env
Expand Down Expand Up @@ -84,4 +85,4 @@ generated/
# Ignore TSDoc directory
docs/

.tool-versions
.tool-versions
17 changes: 16 additions & 1 deletion examples/align-two-surfaces/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,15 @@
<!DOCTYPE html>
<!doctype html>
<html lang="en" xml:lang="en">
<head>
<title>Align Two Surfaces</title>

<script type="module" src="main.js"></script>

<!--
Default: use the published package from the CDN.
To test in-development viewer changes instead, comment this section out and
uncomment the local assets section below.
-->
<link
rel="stylesheet"
href="https://cdn.jsdelivr.net/npm/@vertexvis/viewer@0.24.x/dist/viewer/viewer.css"
Expand All @@ -18,6 +23,16 @@
src="https://cdn.jsdelivr.net/npm/@vertexvis/viewer@0.24.x/dist/viewer.js"
></script>

<!--
Local development: use the local viewer build output instead of the CDN.
Do `yarn workspace @vertexvis/viewer build` and `yarn examples:start`
before enabling this block.
-->

<!--

Check warning on line 32 in examples/align-two-surfaces/index.html

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Remove this commented out code. 


See more on https://sonarcloud.io/project/issues?id=Vertexvis_vertex-web-sdk&issues=AZ3hq1ixgcaH22CkKB_X&open=AZ3hq1ixgcaH22CkKB_X&pullRequest=763
<link rel="stylesheet" href="/packages/viewer/dist/viewer/viewer.css" />
<script type="module" src="/packages/viewer/dist/viewer/viewer.js"></script>
-->
<style>
html,
body {
Expand Down
12 changes: 11 additions & 1 deletion examples/camera-manipulations/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE html>
<!doctype html>
<html lang="en" xml:lang="en">
<head>
<title>Camera Manipulations</title>
Expand All @@ -18,6 +18,16 @@
nomodule
src="https://cdn.jsdelivr.net/npm/@vertexvis/viewer@0.24.x/dist/viewer.js"
></script>
<!--
Local development: use the local viewer build output instead of the CDN.
Do `yarn workspace @vertexvis/viewer build` and `yarn examples:start`
before enabling this block.
-->

<!--

Check warning on line 27 in examples/camera-manipulations/index.html

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Remove this commented out code. 


See more on https://sonarcloud.io/project/issues?id=Vertexvis_vertex-web-sdk&issues=AZ3hq1iNgcaH22CkKB_W&open=AZ3hq1iNgcaH22CkKB_W&pullRequest=763
Copy link
Copy Markdown
Contributor Author

@aeischeid aeischeid May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdm717 sonar doesn't like these commented out bits, but IMO they are quite handy. Is there a way to tell Sonar to ignore these examples/**/index.html files ?

Copy link
Copy Markdown
Collaborator

@jdm717 jdm717 May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like I'm not able to change any of the rules there - I'll take a look at getting the correct permissions to do so next week, but in the meantime if you want to get these to stop showing up on the PR, you can always open the link and click the dropdown where it says Open and choose Accept in the cases where we're not going to take the action Sonar suggests, which should at least cause the Sonar check to pass. It does look like Sonar supports path exclusions though, so it should be possible to get the examples directory omitted later!

Copy link
Copy Markdown
Contributor Author

@aeischeid aeischeid May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got around this. Ended up just putting this comment in the examples dir readme. Easy enough to grab it from there if doing local testing

<link rel="stylesheet" href="/packages/viewer/dist/viewer/viewer.css" />
<script type="module" src="/packages/viewer/dist/viewer/viewer.js"></script>
-->
</head>
<body>
<div>
Expand Down
13 changes: 7 additions & 6 deletions examples/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,16 @@
<html lang="en">
<head>
<meta charset="utf-8" />
<meta
name="viewport"
content="width=device-width, initial-scale=1.0"
/>
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Examples</title>
<style>
:root {
color-scheme: light;
font-family: system-ui, -apple-system, BlinkMacSystemFont, "Segoe UI",
font-family:
system-ui,
-apple-system,
BlinkMacSystemFont,
'Segoe UI',
sans-serif;
}

Expand Down Expand Up @@ -73,7 +74,7 @@
<main>
<div class="back"><a href="/">Back to root</a></div>
<h1>Examples</h1>
<p>Browse the available SDK examples served by Vite.</p>
<p>Browse the available SDK examples</p>
<div class="grid">
<a href="/examples/align-two-surfaces/">
<strong>Align Two Surfaces</strong>
Expand Down
18 changes: 17 additions & 1 deletion examples/phantom-parts/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,15 @@
<!DOCTYPE html>
<!doctype html>
<html lang="en" xml:lang="en">
<head>
<title>Phantom Parts</title>

<script type="module" src="main.js"></script>

<!--
Default: use the published package from the CDN.
To test in-development viewer changes instead, comment this section out and
uncomment the local assets section below.
-->
<link
rel="stylesheet"
href="https://cdn.jsdelivr.net/npm/@vertexvis/viewer@0.24.x/dist/viewer/viewer.css"
Expand All @@ -18,6 +23,17 @@
src="https://cdn.jsdelivr.net/npm/@vertexvis/viewer@0.24.x/dist/viewer.js"
></script>

<!--
Local development: use the local viewer build output instead of the CDN.
Do `yarn workspace @vertexvis/viewer build` and `yarn examples:start`
before enabling this block.
-->

<!--

Check warning on line 32 in examples/phantom-parts/index.html

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Remove this commented out code. 


See more on https://sonarcloud.io/project/issues?id=Vertexvis_vertex-web-sdk&issues=AZ3hq1jLgcaH22CkKB_Y&open=AZ3hq1jLgcaH22CkKB_Y&pullRequest=763
<link rel="stylesheet" href="/packages/viewer/dist/viewer/viewer.css" />
<script type="module" src="/packages/viewer/dist/viewer/viewer.js"></script>
-->

<style>
html,
body {
Expand Down
22 changes: 19 additions & 3 deletions examples/picking/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,39 @@
<!DOCTYPE html>
<!doctype html>
<html lang="en" xml:lang="en">
<head>
<title>Picking</title>

<script type="module" src="main.js"></script>

<!--
Default: use the published package from the CDN.
To test in-development viewer changes instead, comment this section out and
uncomment the local assets section below.
-->
<link
rel="stylesheet"
href="https://cdn.jsdelivr.net/npm/@vertexvis/viewer@0.24.x/dist/viewer/viewer.css"
/>
<script
type="module"
src="https://cdn.jsdelivr.net/npm/@vertexvis/viewer@0.24.x/dist/viewer/viewer.esm.js"
src="https://cdn.jsdelivr.net/npm/@vertexvis/viewer@0.24.x/dist/viewer/viewer.js"
></script>
<script
nomodule
src="https://cdn.jsdelivr.net/npm/@vertexvis/viewer@0.24.x/dist/viewer.js"
src="https://cdn.jsdelivr.net/npm/@vertexvis/viewer@0.24.x/dist/viewer.cjs"
></script>

<!--
Local development: use the local viewer build output instead of the CDN.
Do `yarn workspace @vertexvis/viewer build` and `yarn examples:start`
before enabling this block.
-->

<!--

Check warning on line 32 in examples/picking/index.html

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Remove this commented out code. 


See more on https://sonarcloud.io/project/issues?id=Vertexvis_vertex-web-sdk&issues=AZ3hq1hZgcaH22CkKB_V&open=AZ3hq1hZgcaH22CkKB_V&pullRequest=763
<link rel="stylesheet" href="/packages/viewer/dist/viewer/viewer.css" />
<script type="module" src="/packages/viewer/dist/viewer/viewer.js"></script>
-->

<style>
html,
body {
Expand Down
16 changes: 6 additions & 10 deletions examples/pmi/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,31 +10,27 @@
To test in-development viewer changes instead, comment this section out and
uncomment the local assets section below.
-->
<link
<!--<link

Check warning on line 13 in examples/pmi/index.html

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Remove this commented out code. 


See more on https://sonarcloud.io/project/issues?id=Vertexvis_vertex-web-sdk&issues=AZ3gWqtWkcsfetTnsiCH&open=AZ3gWqtWkcsfetTnsiCH&pullRequest=763
rel="stylesheet"
href="https://cdn.jsdelivr.net/npm/@vertexvis/viewer@0.24.x/dist/viewer/viewer.css"
/>
<script
type="module"
src="https://cdn.jsdelivr.net/npm/@vertexvis/viewer@0.24.x/dist/viewer/viewer.esm.js"
src="https://cdn.jsdelivr.net/npm/@vertexvis/viewer@0.24.x/dist/viewer/viewer.js"
></script>
<script
nomodule
src="https://cdn.jsdelivr.net/npm/@vertexvis/viewer@0.24.x/dist/viewer.js"
></script>
src="https://cdn.jsdelivr.net/npm/@vertexvis/viewer@0.24.x/dist/viewer.cjs"
></script>-->

<!--
Local development: use the local viewer build output instead of the CDN.
Do `yarn workspace @vertexvis/viewer build` and `yarn examples:start`
before enabling this block.
-->

<link rel="stylesheet" href="/packages/viewer/dist/viewer/viewer.css" />
<script
type="module"
src="/packages/viewer/dist/viewer/viewer.esm.js"
></script>
<script nomodule src="/packages/viewer/dist/viewer.js"></script>
-->
<script type="module" src="/packages/viewer/dist/viewer/viewer.js"></script>

<style>
html,
Expand Down
0 internal/build/.eslintrc.js → internal/build/.eslintrc.cjs
View file
Open in desktop
File renamed without changes.
4 changes: 4 additions & 0 deletions internal/build/jest.config.js → internal/build/jest.config.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@ const jestConfig = require('@vertexvis/jest-config-vertexvis/jest.config');

module.exports = {
...jestConfig,
setupFilesAfterEnv: [
...(jestConfig.setupFilesAfterEnv || []),
'<rootDir>/../../jest.setup.console.js',
],
coverageThreshold: {
global: {
branches: 90,
Expand Down
38 changes: 28 additions & 10 deletions internal/build/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,32 +19,50 @@
"tsconfig.json",
"tsconfig-web.json"
],
"main": "./dist/bundle.cjs.js",
"module": "./dist/bundle.esm.js",
"typings": "./dist/index.d.ts",
"type": "module",
"main": "./dist/bundle.cjs",
"module": "./dist/bundle.js",
"types": "./dist/index.d.ts",
"exports": {
".": {
"types": "./dist/index.d.ts",
"import": "./dist/bundle.js",
"require": "./dist/bundle.cjs",
"default": "./dist/bundle.js"
},
"./tsconfig": {
"default": "./tsconfig.json"
},
"./tsconfig-web": {
"default": "./tsconfig-web.json"
}
},
"scripts": {
"clean": "rm -fr ./dist && mkdir ./dist",
"prebuild": "yarn clean",
"build": "rollup --config ./rollup.config.js",
"build": "rollup --config ./rollup.config.js && tsc --project tsconfig.json --emitDeclarationOnly --declaration --outDir dist",
"format": "yarn lint --fix",
"lint": "eslint --ext .ts,.tsx,.js,.jsx --ignore-path ../../.gitignore .",
"start": "jest --watch",
"test": "jest",
"test": "jest --runInBand",
"test:coverage": "yarn test --coverage"
},
"dependencies": {
"@vertexvis/build-tools": "^0.10.2",
"@rollup/plugin-commonjs": "^21.1.0",
"@rollup/plugin-node-resolve": "^13.3.0",
"@vertexvis/typescript-config-vertexvis": "1.1.0",
"tslib": "^2.1.0"
"rollup-plugin-terser": "^7.0.2",
"tslib": "^2.4.0",
"typescript": "^5.2.0"
},
"devDependencies": {
"@types/jest": "^27.5.1",
"@types/jest": "^29.5.14",
"@vertexvis/eslint-config-vertexvis-typescript": "^0.5.0",
"@vertexvis/jest-config-vertexvis": "^0.5.4",
"eslint": "^8.57.1",
"jest": "^27.5.1",
"jest": "^29.5.14",
"rollup": "^2.80.0",
"ts-jest": "^27.1.4"
"ts-jest": "^29.4.9"
},
"peerDependencies": {
"rollup": "^2"
Expand Down
Loading
Loading