Skip to content

[PLAT-8122] upgrade framework - Next v16.2 & React 19.2 #224

Open
aeischeid wants to merge 12 commits intomainfrom
next16forRealz
Open

[PLAT-8122] upgrade framework - Next v16.2 & React 19.2 #224
aeischeid wants to merge 12 commits intomainfrom
next16forRealz

Conversation

@aeischeid
Copy link
Copy Markdown
Contributor

@aeischeid aeischeid commented Apr 22, 2026

Summary

Move the framework version up to Next 16 and also React to v 19

Test Plan

One goal of this upgrade is to test react19 compatibility coming in web-sdk. On deployed contexts will need newly released version of vertex-web-sdk to be available, which we don't have a definitive timeline on yet, but we're actively working on it and making good progress, so hopefully coming soon

Release Notes

Should be compatible with Vertexvis/vertex-web-sdk#729

Possible Regressions

While using older versions of vertex-web-sdk (< 0.25.x ?) may see complaints about unmatched peerDependencies, but in initial testing I haven't yet seen anything that is actually broken

Dependencies

New versions of esLint along for the ride

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Apr 22, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nextjs-starter Ready Ready Preview, Comment May 2, 2026 2:06am

Request Review

Comment thread next.config.ts
Comment on lines +34 to +38
"react/jsx-runtime": path.join(process.cwd(), "node_modules/react/jsx-runtime"),
"react/jsx-dev-runtime": path.join(
process.cwd(),
"node_modules/react/jsx-dev-runtime"
),
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these entries are here to keep mismatch version of react from local @vertexvis/viewer-react from conflicting. Could be commented out or maybe added as instruction for local sdk testing in readme 🤔

Comment thread package.json
"build:turbopack": "next build",
"clean": "rm -rf .next/ node_modules/",
"dev": "next",
"dev": "next dev --webpack",
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new Next.js wants turbopack. Something with local yarn linking was really not liking turbopack, but seems to work fine when that isn't in play

Comment thread README.md
- [Vercel](https://nextjs.org/docs/deployment)
- [Netlify](https://www.netlify.com/blog/2020/11/30/how-to-deploy-next.js-sites-to-netlify/)
- [AWS CDK](https://github.com/serverless-nextjs/serverless-next.js#readme)
- [AWS via OpenNext](https://opennext.js.org)
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

serverless-next is dead project 😿 . superseded in spirit by OpenNext

@aeischeid aeischeid requested a review from amvertex April 22, 2026 17:47
@aeischeid aeischeid marked this pull request as ready for review April 22, 2026 17:48
@aeischeid aeischeid requested a review from a team as a code owner April 22, 2026 17:48
Comment thread src/components/Home.tsx Outdated
const nextUrl = encodeCreds(credentials);
if (router.asPath === nextUrl) return;

void router.replace(nextUrl, undefined, { shallow: true });
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need void here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, shouldn't. Will clean

Comment thread src/lib/viewer.ts Outdated
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 2, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants