🥢 Nit Comment in FixedMathPointLib#814
Merged
Vectorized merged 1 commit intoVectorized:mainfrom Jan 31, 2024
pcaversaccio:fix-comment-expwad
Merged
🥢 Nit Comment in FixedMathPointLib#814Vectorized merged 1 commit intoVectorized:mainfrom pcaversaccio:fix-comment-expwad
Vectorized merged 1 commit intoVectorized:mainfrom
pcaversaccio:fix-comment-expwad
Conversation
atarpara
changed the title
expWad on Negative Threshold
Owner
|
Thanks so much for the sharp eye. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As title. The updated threshold (via #757) can be calculated using
math.log(1e-18) * 1e18in Python (with a small precision loss in the last 3 digits).Checklist
Ensure you completed all of the steps below before submitting your pull request:
forge fmt?forge snapshot?forge test?