Fix disabled Mute button by exporting ClientFactory#3984
Open
gss-crazydog wants to merge 1 commit intoValveSoftware:masterfrom
Open
Fix disabled Mute button by exporting ClientFactory#3984gss-crazydog wants to merge 1 commit intoValveSoftware:masterfrom
gss-crazydog wants to merge 1 commit intoValveSoftware:masterfrom
Conversation
The GameUI requires the `IGameClientExports` interface from the Client DLL to manage player muting (checking status and toggling block state). Previously, the GameUI could not locate this interface because the client was not exposing its interface factory. This change: - Exports `ClientFactory` from cdll_int.cpp to return the client's internal interface factory (`Sys_GetFactoryThis`). - Updates the `cldll_func_t` struct to include `ClientFactory` while passing `nullptr` for `pGetPlayerTeam` to skip its implementation and maintain alignment. See also ValveSoftware#1641 --- `GetServerHostName` in `CClientExports` could also be updated to actually return the server's hostname to display in the Player List dialog's title, but it is not necessary for this fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GameUI requires the
IGameClientExportsinterface from the Client DLL to manage player muting (checking status and toggling block state). Previously, the GameUI could not locate this interface because the client was not exposing its interface factory.This change:
ClientFactoryfrom cdll_int.cpp to return the client's internal interface factory (Sys_GetFactoryThis).cldll_func_tstruct to includeClientFactorywhile passingnullptrforpGetPlayerTeamto skip its implementation and maintain alignment.See also #1641
GetServerHostNameinCClientExportscould also be updated to actually return the server's hostname to display in the Player List dialog's title, but it is not necessary for this fix.