Skip to content

feat(CustomSelect): shows clear button when typing in search#10029

Open
SevereCloud wants to merge 1 commit into
masterfrom
SevereCloud/feat/shows-clear-button-when-typing-in-search
Open

feat(CustomSelect): shows clear button when typing in search#10029
SevereCloud wants to merge 1 commit into
masterfrom
SevereCloud/feat/shows-clear-button-when-typing-in-search

Conversation

@SevereCloud

Copy link
Copy Markdown
Contributor
  • Unit-тесты
  • e2e-тесты
  • Дизайн-ревью
  • Документация фичи
  • Release notes

Описание

Показываем крестик при фокусе на поиске в CustomSelect

Release notes

Улучшения

  • CustomSelect: Показываем кнопку очистки при фокусе на поиске

@SevereCloud
SevereCloud requested a review from a team as a code owner July 6, 2026 11:06
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
JS 425.7 KB (+0.05% 🔺)
JS (gzip) 131.31 KB (+0.06% 🔺)
JS (brotli) 108.25 KB (-0.05% 🔽)
JS import Div (tree shaking) 811 B (0%)
CSS 382.47 KB (0%)
CSS (gzip) 46.84 KB (0%)
CSS (brotli) 36.94 KB (0%)

@SevereCloud
SevereCloud force-pushed the SevereCloud/feat/shows-clear-button-when-typing-in-search branch from 6d41dde to 1d76d8f Compare July 6, 2026 11:12
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

e2e tests

Playwright Report

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

📊 Найдены изменения в собранных файлах: Отчет

Commit 1d76d8f

@codecov

codecov Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.22%. Comparing base (be320f8) to head (1d76d8f).
⚠️ Report is 46 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10029      +/-   ##
==========================================
- Coverage   95.23%   95.22%   -0.01%     
==========================================
  Files         462      462              
  Lines       12518    12685     +167     
  Branches     4479     4549      +70     
==========================================
+ Hits        11921    12079     +158     
- Misses        597      606       +9     
Flag Coverage Δ
unittests 95.22% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/10029/1d76d8f8d11337d6b7016aff5d4ee6965caf894f/pkg/@vkontakte/vkui/_pkg.tgz

Commit 1d76d8f

@inomdzhon inomdzhon added this to the v8.4.0 milestone Jul 6, 2026
@inomdzhon inomdzhon added this to VKUI Jul 6, 2026
@inomdzhon inomdzhon moved this to 👀 In Review in VKUI Jul 6, 2026
@vkcom-publisher vkcom-publisher added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Jul 14, 2026
@vkcom-publisher

Copy link
Copy Markdown
Contributor

PR закрыт из-за отсутствия активности в течение последних 14 дней. Если это произошло по ошибке или изменения все ещё актуальны, откройте PR повторно.

@github-project-automation github-project-automation Bot moved this from 👀 In Review to ✅ Done in VKUI Jul 21, 2026
@inomdzhon inomdzhon added no-stale Добавляет PR в исключения для автоматического закрытия and removed pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности labels Jul 21, 2026
@inomdzhon inomdzhon reopened this Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cmp:custom-select no-stale Добавляет PR в исключения для автоматического закрытия type:feature

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants