Skip to content

Add cargo features build arg to Docker build #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TreehouseFalcon wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add cargo features build arg to Docker build #187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ services:
build:
context: .
dockerfile: wally-registry-backend/Dockerfile
args:
- WALLY_BACKEND_BUILD_FEATURES=${WALLY_BACKEND_BUILD_FEATURES}
ports:
- "8000:8000"

Expand Down
11 changes: 9 additions & 2 deletions wally-registry-backend/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,20 @@ COPY wally-registry-backend/Cargo.toml /usr/app/wally-registry-backend/
COPY Cargo.toml Cargo.lock /usr/app/
COPY src/ /usr/app/src/

RUN cargo build --package wally-registry-backend --release
ARG WALLY_BACKEND_BUILD_FEATURES
RUN if [ -n "$WALLY_BACKEND_BUILD_FEATURES" ]; then \
cargoFeatures="--features $WALLY_BACKEND_BUILD_FEATURES"; \
fi && \
cargo build --package wally-registry-backend --release $cargoFeatures

# Copy actual application source in and force a modified timestamp so that
# Cargo will rebuild.
COPY ./wally-registry-backend ./wally-registry-backend/
RUN touch wally-registry-backend/src/main.rs
RUN cargo build --package wally-registry-backend --release
RUN if [ -n "$WALLY_BACKEND_BUILD_FEATURES" ]; then \
cargoFeatures="--features $WALLY_BACKEND_BUILD_FEATURES"; \
fi && \
cargo build --package wally-registry-backend --release $cargoFeatures

FROM debian:buster-slim

Expand Down