Remove unused OKX auth; always fetch X Layer source unauthenticated - #920
Merged
Conversation
The OKX verify-contract-info endpoint is public and returns verified source without any OK-ACCESS-* signature headers. Our code required OKX_ACCESS_KEY/SECRET_KEY/PASSPHRASE and hard-failed before making the request when they were unset (which they always were), so X Layer hook submissions were incorrectly labeled unverified. Drop the signing path entirely and always do a plain curl, matching what a browser does. Also remove the now-unused OKX_* secret env vars from the analyze-hook and review-hook workflows. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
X Layer (OKX) hook submissions were failing source verification in CI (e.g. run 28876960754, issue #709). The
Fetch sourcestep aborted with:The
OKX_*repo secrets are unset, sofetch_source.pyraised before ever contacting OKX and the hook got labeledunverified.Root cause
The OKX
verify-contract-infoendpoint is public — it returns verified source with noOK-ACCESS-*signature headers. You can hit it directly in a browser:Our code assumed OKX's signed-request scheme (correct for trading/account APIs) was needed here. It wasn't — and the required secrets were never populated anyway, making the automated path impossible to satisfy.
Fix
okx_curl_argssigning helper and always do a plain unauthenticatedcurl, matching browser behavior — for both the primary and proxy-implementation fetches.OKX_ACCESS_KEY/OKX_SECRET_KEY/OKX_PASSPHRASEenv vars from theanalyze-hookandreview-hookworkflows.Verification
Ran the updated script against the live endpoint:
🤖 Generated with Claude Code