Add SpcxStrategyHook hook on robinhood#1124
Merged
marktoda merged 1 commit intoJul 21, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Review: hooks/robinhood/0xf7c46f4ddb5d6b8c6a040e19cf2064e832d32444.json
Flags
Address last 14 bits: 0x2444 → bits 13, 10, 6, 2 set.
| Flag | Address bit | JSON | Source getHookPermissions() |
|---|---|---|---|
| beforeInitialize | 1 | true |
true ✓ |
| afterInitialize | 0 | false |
false ✓ |
| beforeAddLiquidity | 0 | false |
false ✓ |
| afterAddLiquidity | 1 | true |
true ✓ |
| beforeRemoveLiquidity | 0 | false |
false ✓ |
| afterRemoveLiquidity | 0 | false |
false ✓ |
| beforeSwap | 0 | false |
false ✓ |
| afterSwap | 1 | true |
true ✓ |
| beforeDonate | 0 | false |
false ✓ |
| afterDonate | 0 | false |
false ✓ |
| beforeSwapReturnsDelta | 0 | false |
false ✓ |
| afterSwapReturnsDelta | 1 | true |
true ✓ |
| afterAddLiquidityReturnsDelta | 0 | false |
false ✓ |
| afterRemoveLiquidityReturnsDelta | 0 | false |
false ✓ |
All flags match. ✓
Properties
- dynamicFee:
false— NobeforeSwap, noupdateDynamicLPFee()call. The hook takes fees viaafterSwapReturnsDelta, not an LP fee override. ✓ - upgradeable:
false— No proxy,delegatecall, orSELFDESTRUCT.source_meta.jsonconfirms"proxy": false. ✓ - requiresCustomSwapData:
false— ThehookDataparameter in_afterSwapis never decoded or inspected; swaps succeed with empty bytes. ✓ - vanillaSwap:
false— Correct;afterSwapReturnsDeltaistrueand the hook materially alters swap output by skimming fees. ✓ - swapAccess:
"none"— NobeforeSwapflag; the hook'sExactOutputNotAllowedrevert is a swap-type restriction (not caller-based access control), and the bootstrapper exemption is an internal fee bypass, not a swap gate. ✓
Metadata
- name
"SpcxStrategyHook"matches the on-chain contract name. ✓ - chainId
4663matcheschains.jsonentry for"robinhood". ✓ - verifiedSource:
truematchessource_meta.json"verified": true. ✓ - description is accurate and fully substantiated by the source:
- Decaying buy tax 95%→10%: confirmed by
STARTING_BUY_FEE = 9_500,DEFAULT_FEE = 1_000,DECAY_STEP_SECONDS = 60incalculateFee(). ✓ - Flat 10% sell tax: confirmed by
calculateFee(false)returningDEFAULT_FEE. ✓ - Token→ETH conversion via nested swap: confirmed by
_swapToEth(). ✓ - ETH shortfalls as ERC-6909 claims: confirmed by
_takeEthOrDefer()callingpoolManager.mint(). ✓ - 90/10 split to mutable controller/dev: confirmed by
TREASURY_PCT = 90,setController(),setDev(). ✓ - Exact-output unconditionally reverted: confirmed by
if (params.amountSpecified > 0) revert ExactOutputNotAllowed(). ✓ - No promotional, audit, safety, or unsubstantiated language. ✓
- Decaying buy tax 95%→10%: confirmed by
All checks pass.
marktoda
approved these changes
Jul 21, 2026
marktoda
left a comment
Contributor
There was a problem hiding this comment.
Bot review verified. SpcxStrategyHook (robinhood). Flags: beforeInitialize, afterAddLiquidity, afterSwap, afterSwapReturnsDelta. Description 430 chars (under limit). LGTM.
marktoda
deleted the
hooks/robinhood/0xf7c46f4ddb5d6b8c6a040e19cf2064e832d32444
branch
July 21, 2026 16:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A fee-taking hook for a single ETH/SPCXSTR pool that charges a decaying buy tax (95%→10% at ~1%/min via block.timestamp) and a flat 10% sell tax via afterSwapReturnsDelta. Token-denominated fees are converted to ETH mid-swap via a nested pool swap; ETH shortfalls are deferred as ERC-6909 claims. Collected ETH is split 90/10 between a mutable controller address and a dev address. Exact-output swaps are unconditionally reverted.
Flags
Properties
Warnings
Closes #1123