Add Grib2 Pds 40 Type#1568
Merged
Merged
Conversation
|
|
lesserwhirls
approved these changes
Jun 19, 2026
lesserwhirls
left a comment
lesserwhirls
left a comment
Member
There was a problem hiding this comment.
This looks great, thank you for your contribution! I've added some tests locally and will make a separate PR for those. Happy to merge this in whenever you are ready.
Member
|
Actually, looks like it is ready now. Merging. |
Contributor
Author
|
Thanks for the quick work, happy to help :) |
5 tasks
lesserwhirls
added a commit
that referenced
this pull request
Jun 19, 2026
Add tests for GRIB2 PDS 40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
This PR only adds support for the 4.40 Template type. It is basically a copy of the other types, but following the structure doc 4.40: https://www.cosmo-model.org/content/model/cosmo/grib/pdtemplate_4.40.htm
Has been tested on a File provided by MeteoSwiss: Kenda OGD -> Parameter
POACsncPR Checklist
until ready for review