Repository navigation
feat: enable BFA funding in Lightning RGB wallets - #54
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BFA channel funding is rejected by the internal Lightning RGB wallet because BFA is missing from its supported schemas and the funding acceptor opens the wallet without an Ethereum RPC endpoint.
Read the optional Ethereum RPC endpoint from the Lightning KV store, enable BFA when it is configured, and pass it to
rgb-libwhen accepting funding consignments. A shared schema selector keeps node and Lightning wallets consistent, including IFA's mainnet restriction. Missing or empty endpoints preserve the existing behavior for wallets without BFA.Use the released
rgb-libtagv0.3.0-beta.50-bfain bothlightningandlightning-invoice. It includes the merged BFA metadata validation fix from rgb-lib#113. Includes unit tests for legacy/disabled endpoint configuration and schema selection.Companion node integration: rgb-lightning-node#205.
Validation:
rust-lightning/dev(fc5c4c64d).v0.3.0-beta.50-bfasource (1b951af0).rgb-libpin (4d65421), which passedcargo check --locked --features uniffi,vls,vss,test-utils --all-targetsthrough the companion node. Compilation was not repeated for this tag-only update.rgb-libfix (840e22a): channel funding, multihop payments, restart, cooperative and force close, and an on-chain burn. The lifecycle has not been rerun with the release tag.git diff --checkpasses with this update. The new LDK unit tests have not been run separately.Standalone CI was already failing on
dev: the Ubuntu build log shows Cargo cannot resolve the yankedsecp256k1 0.32.0-beta.2dependency. The companion node supplies its existing pinned BFA dependency patches; this PR does not change standalone dependency resolution or CI configuration.