Repository navigation
fix: prevent send_end panic on extra allocations (upstream #114) - #110
Merged
Merged
Conversation
Add two tests, one for a regular send and one for a donation, where a single colorable UTXO holds two assets and only one of them is sent through send_begin with dry_run = false. The other asset is moved to change as an extra allocation and persisted as a non-user-driven asset transfer on the Initiated batch. Both tests currently fail: send_end panics in update_or_save_transfers with "exists at this point" when it looks the extra allocation up in info_contents.transfers. The following commit fixes this. Co-Authored-By: Claude (cherry picked from commit a745fa3)
(cherry picked from commit 151bf61)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cherry-picks RGB-Tools/rgb-lib#114, updating transport endpoint flags through actual recipients so extra allocations are skipped. It includes regression tests for both regular sends and donations.
Additional change for this fork: passed None for the fork-specific lock_time argument in the regression test’s send_begin call. This compatibility adjustment is a separate commit; the production fix is unchanged from upstream.