Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex security review |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
gofman8
changed the title
gofman8
changed the title
|
@codex security review |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
gofman8
changed the title
(latest, safe or finalized, default safe). The BFA mint lock now follows the same tag instead of a hardcoded finalized block plus a confirmation floor, and keeps the block > afterBlock rule. Both sides changed the attested policy, so it becomes version 10 with evm_finality_tag and spv_min_confirmations; V8 and V9 are refused. The rgb-lib receiver still accepts the mint only once the deposit is finalized, so with safe the enclave signs before the user sees the mint.
Before #313 a production policy refused EVM_MIN_CONFIRMATIONS=0. #313 dropped that, so a production enclave could accept a deposit with no confirmation. The boot and launch gates, the parent launch check and attest-verify now refuse EVM_FINALITY_TAG=latest in production; development builds may still use it. The mint image checks the previous mint of a right lane at SPV_MIN_CONFIRMATIONS, now 3 to match the bridge's INIT_OP_MIN_CONFIRMATIONS; the burn image keeps 6. attest-verify expects the depth of the signer role by default. verify_rgb_funds_in notes why a non-finalized tag is enough for the mint lock.
2 participants
Configure EVM deposit verification with
EVM_FINALITY_TAG=latest|safe|finalized, defaulting tosafe. Both FundsIn authorization paths require a successful receipt at or below the selected head, a matching canonical block hash, and a consistent head snapshot across verification. Invalid configuration stops startup; unavailable or invalid RPC data refuses signing.Policy V9 commits the selected tag. The launch verifier reads it from the measured image, the standalone verifier requires
--expect-evm-finality-tag, and clone peers must match. Deploy matching EIF and parent/verifier releases with approved PCRs. The documentation describes the current tag choices and their Arbitrum behavior.Validation for
c368c067625a3f1fb3f9c69109c4bbd7da407a25:The pinned RPC remains trusted for chain correctness; the selected tag determines the accepted reorg risk.