Feat 176 single bulk assignment refactor#247
Conversation
|
[Question] Is the description field not mandatory? Without filling it out, I, as a user, can still submit the form. 
|
|
[Bug] When creating a new assignment by clicking on "Add Assignment" button, the End Time of an assignment can be set before the Start Time. |
|
[Bug] It's not in this pull request's scope😂, but I accidentally discovered if I click on the "Closed" tag, there would be this error "Uncaught TypeError: can't access property "closest", this._element is null". (All CARE platform shares this error.) 
Update: I am not sure if it has anything to do with this issue: #178 |
pdji1602003
left a comment
pdji1602003
left a comment
There was a problem hiding this comment.
I just finished the review. Thank you for the hard work. I like how you use provide/inject for shared confirmation/distribution state to avoid deep prop drilling and also the idea of turning each step into an independent component for the separation of responsibility. :)
NAO-200
left a comment
NAO-200
left a comment
There was a problem hiding this comment.
LGTM. I left a few minor comments regarding readability and maintainability, but overall the changes look good 👍
No its not mandatory |
|
Thanks so much for your comments I found them very helpful I went through them and fixed all that required fixing please take another look @pdji1602003 @NAO-200 |
| </template> | ||
|
|
||
| <script> | ||
| import StepperModal from "@/basic/modal/StepperModal.vue"; |
There was a problem hiding this comment.
Docstring is missing
There was a problem hiding this comment.
I guess not its just down bellow
| }); | ||
| }, | ||
| createSingleAssignment() { | ||
| this.$refs.assignmentStepper.startProgress(); |
There was a problem hiding this comment.
The progressId is not send here to the backend. Is it needed for single Assignment?
There was a problem hiding this comment.
The progressId is used for tracking the progress of the bulk operation. In this case there is no bulk operation therefore we dont need to send the progressId to the backend
4 participants
###Main Description
This pull request introduces a refactor to the single and bulk assignment
New Dev Features