Skip to content

Draft ADR for using devise for auth#1546

Merged
james merged 1 commit into
developfrom
ADR/devise
Feb 4, 2022
Merged

Draft ADR for using devise for auth#1546
james merged 1 commit into
developfrom
ADR/devise

Conversation

@james
Copy link
Copy Markdown
Contributor

@james james commented Jan 25, 2022

No description provided.

@rgarner
Copy link
Copy Markdown
Contributor

rgarner commented Jan 26, 2022

@CristinaRO we know, and so do they 😄 I was just saying to @james yesterday that it's ironic that the 15th C spelling is in a 21st C repo. Bit of historical flavour for you...

@james james force-pushed the ADR/devise branch 2 times, most recently from 65d6d19 to 92939b6 Compare February 4, 2022 14:53
@james james marked this pull request as ready for review February 4, 2022 14:53
Copy link
Copy Markdown
Contributor

@CristinaRO CristinaRO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with comments!


## Context

We previously used Auth0, via omniauth, to manage users and sessions. We have a user requirement to require MultiFactor authentication using one-time passwords sent over SMS. Auth0 are planning on moving this feature to only be inlcluded in expensive enterprise plans.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo "inlcluded"

@@ -0,0 +1,27 @@
# 34. Use devise and rotp to manage authentication with sms OTP
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would prefer "SMS" for style consistency.

@james james merged commit b4bfabe into develop Feb 4, 2022
@james james deleted the ADR/devise branch February 4, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants