Skyhight173/json: add cache to improve performance#2457
Open
LegoBrainBiker wants to merge 10 commits into
Open
Skyhight173/json: add cache to improve performance#2457LegoBrainBiker wants to merge 10 commits into
LegoBrainBiker wants to merge 10 commits into
Conversation
github-actions
Bot
added
the
pr: change existing extension
Contributor
Author
|
!format |
Contributor
Author
|
!format |
GarboMuffin
reviewed
Apr 10, 2026
| const objectCache = {}; | ||
| function parse(string) { | ||
| return ( | ||
| objectCache[string] ?? |
Member
There was a problem hiding this comment.
never write code like this. clever code is bad and unreadable
Contributor
Author
There was a problem hiding this comment.
is it acceptable without the timeout?
Member
There was a problem hiding this comment.
i was referring to objectCache[string] ?? (objectCache[string] = JSON.parse(string)); which is very indicipherable to normal people
GarboMuffin
reviewed
Apr 10, 2026
Contributor
Author
|
!format |
Fix setInterval usage to correctly clear the cache.
GarboMuffin
reviewed
May 16, 2026
Contributor
Author
|
!format |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the json extension can be slow because it needs to parse and stringify each time a block is called. this pr adds a cache so that if the json was recently created by the project, it can be looked up without using JSON.parse.