Repository navigation
Add account owner and PDA validation to vote and execute instructions - #37
Merged
Merged
Conversation
Removed audit comments regarding transaction execution.
Collaborator
|
sorry for the delay. |
Removed checks for illegal owners in transaction execution.
Contributor
Author
|
I removed the owner checks since validate_pda already handles it. |
Collaborator
|
there is still owner check for multisig and derived address comparisonf or multisig is also not needed. coz if the multisig is not valid, user will not be able to create the proposal in the first place and since we are validating the proposal PDA that takes care of multisig as well. |
Removed owner checks for multisig and proposal accounts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds validation to ensure that both the proposal and multisig accounts are owned by the program and that their PDAs are correctly derived.
This prevents execution or voting using foreign proposals or fake PDAs.
Changes
multisig,proposal, andtransactionaccounts.ProposalState::validate_pdain bothvoteandexecute_transactioninstructions.