fix(cientos): PointerLockControls emits too many events#1397
Open
alvarosabu wants to merge 1 commit intomainfrom
Open
fix(cientos): PointerLockControls emits too many events#1397alvarosabu wants to merge 1 commit intomainfrom
alvarosabu wants to merge 1 commit intomainfrom
Conversation
✅ Deploy Preview for cientos-tresjs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for tresjs-lab ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for tresjs-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the bug where
PointerLockControlsemitsisLock/changeevents multiplied by the number of clicks on the canvas. On every click the component was callingaddEventListeneron the Three.js controls instance, so each subsequent lock/unlock fired one additional listener.Root cause
packages/cientos/src/core/controls/PointerLockControls.vue— theuseEventListener('click', ...)handler registered freshlock/unlock/changelisteners on the controls instance on every click, andonUnmountedtried to remove them with new arrow functions that never matched the registered ones (so cleanup was a no-op).Changes
onLock,onUnlock,onChange) soremoveEventListeneractually removes them.controlsRefresolves, not per click.controlsRefchange (viaoldValue) and on unmount.value.lock()+invalidate().Test plan
pnpm --filter playground dev, opencientos/controls/PointerLockControlsDemois-active true/is-active falselog exactly once per transition (no duplicates)changelogs smoothly, no N× duplicationCloses TRES-267