Skip to content

Standardize child passenger indicator to isChild#681

Draft
Copilot wants to merge 2 commits intomasterfrom
copilot/fix-child-indicator-usage
Draft

Standardize child passenger indicator to isChild#681
Copilot wants to merge 2 commits intomasterfrom
copilot/fix-child-indicator-usage

Conversation

Copy link
Copy Markdown

Copilot AI commented Mar 12, 2026

Two property names (child and isChild) were used interchangeably to flag child passengers, causing inconsistency between the search/price path and the booking path.

Changes

  • convert-passengers-object-to-array.js — rename childisChild, drop // quickfix comment
  • AIR_PRICE_REQ, AIR_AVAILABILTIY_REQUEST, AIR_LOW_FARE_SEARCH_REQUEST templates — update {{#if child}}{{#if isChild}}
  • convert-passengers-object-to-array.test.js — update assertions to match
// Before
list.push({ ageCategory, child: (ageCategory === 'CNN') }); // quickfix

// After
list.push({ ageCategory, isChild: (ageCategory === 'CNN') });
Original prompt

This section details on the original issue you should resolve

<issue_title>Which way to indicate child? isChild or child?</issue_title>
<issue_description>There's two way to indicate a passenger is a children,

in Air/Services/transformer/add-meta-passengers-booking.js

      item.isChild = true;

in Air/Services/transformer/convert-passengers-object-to-array.js

          child: (ageCategory === 'CNN'), // quickfix

This makes really confusing, to them or to implement other features. Can you sort them out? </issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: Smotrov <7815789+Smotrov@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix inconsistent child indication methods Standardize child passenger indicator to isChild Mar 12, 2026
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Which way to indicate child? isChild or child?

2 participants