Fix fullscreen engagement panel on newer YouTube versions - #156
Open
Noel-0 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Recent YouTube versions use
YTFullscreenEngagementOverlayControllerfor the fullscreen recommendations/engagement overlay. The existingYTColdConfig.isLandscapeEngagementPanelEnabledhook remains in place for older versions, and this patch also forces the newer controller'ssetEnabled:setter off when the existingDisablesEngagementPanelpreference is enabled.This reuses the current Disables engagement panel in fullscreen setting. No new preference or localization is needed.
Why
On YouTube 21.34.3, enabling the existing setting still allowed the swipe-up recommendations overlay to appear in fullscreen.
Discussion and cross-device comparison: Issue #157.
Validation
The test IPA was built by replacing only
YouMod.dylibin the working driftywinds IPA. This preserved the original bundle identifier and avoided duplicate tweak injection.The additional controller hook follows the compatibility approach already used by YTLitePlus.