Skip to content

feat(review): add comments and suggestion mode#216

Merged
ThisIs-Developer merged 19 commits into
mainfrom
feature/comments-suggestion-mode
Jul 13, 2026
Merged

feat(review): add comments and suggestion mode#216
ThisIs-Developer merged 19 commits into
mainfrom
feature/comments-suggestion-mode

Conversation

@ThisIs-Developer

@ThisIs-Developer ThisIs-Developer commented Jul 12, 2026

Copy link
Copy Markdown
Owner

What changed

  • add a read-only Review workspace for comments and suggestions attached to rendered YAML frontmatter, headings, paragraphs, code blocks, and diagrams
  • keep one Review control in the main toolbar: icon-only with no open feedback, then the chat icon and count together using the existing active style
  • show separate controls on reviewed targets for reading saved feedback and adding another review item
  • support follow-up feedback plus editing, resolving, reopening, and deleting individual review items
  • record and display each thread's opened date/time and closed date/time; reopening clears the closed time until the item is resolved again
  • expand Copy summary with its generated time, total/open/resolved counts, per-item status, opened time, and closed time
  • close Review mode automatically when New Tab is selected, while preserving the previous tab's view mode
  • provide Open, Resolved, and All filters plus Copy summary, Resolve all, and confirmation-protected Delete all actions
  • keep the saved thread list and composer in one responsive panel: compact desktop sidebar, tablet drawer, and touch-friendly mobile bottom sheet
  • persist Review data per normal local tab and synchronize Review changes, including closed timestamps, in both directions during Live Share
  • keep view-only Live Share participants unable to edit Markdown while allowing them to create and manage Review feedback
  • exclude Review state from Share Snapshot and exported document formats
  • allow Share Snapshot and Live Share requests from this project's HTTPS Cloudflare Pages preview subdomains
  • update Reset all files to use the same in-app confirmation modal pattern as destructive Review actions
  • update the README, changelog, feature documentation, and usage guide

Why

Reviewers need to leave structured feedback without directly editing Markdown. The target controls clearly separate reading existing feedback from adding another item, while the lifecycle timestamps and richer summary make review handoff and completion easier to audit.

Closing Review mode before creating a tab prevents a new blank document from inheriting the review workspace and restores the reviewed document's prior editor/preview layout.

Behavior and limits

  • suggestions are feedback records and do not apply source changes automatically
  • normal tabs keep Review data in the existing local workspace; duplicated tabs start without Review threads
  • older resolved records without a stored closing time display Closed: Unavailable
  • Share Snapshot transfers Markdown only and excludes Review threads
  • Live Share synchronizes Markdown and Review data through separate Yjs documents and message types
  • view-only Live Share participants can manage Review feedback but cannot mutate Markdown
  • HTTPS origins matching *.markdownviewer.pages.dev are accepted; lookalike domains, HTTP previews, explicit ports, and unrelated Pages projects remain rejected
  • no authentication, database, server-side Review storage, new dependency, or new color palette was added

Validation

  • node --check script.js
  • node desktop-app/prepare.js
  • npm run build
  • Review Mode suite: 10/10 passed
  • Live Share Review synchronization test passed, including closed timestamp propagation
  • verified the new-tab action closes Review mode and restores the prior tab view
  • verified web/desktop script and stylesheet parity
  • git diff --check

@vercel

vercel Bot commented Jul 12, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
markdown-viwer Ready Ready Preview, Comment Jul 13, 2026 9:48pm

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 12, 2026

Copy link
Copy Markdown

Deploying markdownviewer with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4773acd
Status: ✅  Deploy successful!
Preview URL: https://d2a531fc.markdownviewer.pages.dev
Branch Preview URL: https://feature-comments-suggestion.markdownviewer.pages.dev

View logs

@ThisIs-Developer

Copy link
Copy Markdown
Owner Author

@copilot resolve the merge conflicts in this pull request

Copilot AI commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request

Done — I resolved the merge conflicts and merged origin/main into this branch in commit 4ea6b03.

@ThisIs-Developer ThisIs-Developer marked this pull request as ready for review July 13, 2026 21:51
@ThisIs-Developer ThisIs-Developer merged commit 72c7888 into main Jul 13, 2026
5 checks passed
@ThisIs-Developer ThisIs-Developer deleted the feature/comments-suggestion-mode branch July 14, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants