Open
Conversation
Contributor
Author
|
will let you know when merge , is the air formatter working correctly ? I keep encountering the error from time to time, though I thought I am always formatting with it.. [UPDATE] fixed on my side sry |
ColinFay
reviewed
Apr 17, 2026
| extract = c("ask", "yes", "no"), | ||
| delete_zip = c("ask", "yes", "no") | ||
| ) { | ||
| signal_arg_is_deprecated( |
| cli_abort_dir_create() | ||
| } | ||
|
|
||
| HTML_BUNDLE <- check_if_html_bundle(url) |
Member
There was a problem hiding this comment.
Can you rename in lowercase please ?
| name <- build_name(name, url, with_ext = TRUE) | ||
|
|
||
| if (file_ext(name) != "zip") { | ||
| name <- sprintf("%s.zip", file_path_sans_ext(name)) |
Member
There was a problem hiding this comment.
The idea for this param is to name the output file that is put inside the www folder, I'm not sure it provides value to allow this to be named as a .zip ? Given that the html Template will be an .html file and the .zip removed
| "css", | ||
| "html" | ||
| "html", | ||
| "zip" |
Member
There was a problem hiding this comment.
I'm not sure this function is ever called with the zip param ?
Contributor
Author
|
so the behavior is now:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #848