Draft
Conversation
NonSwag
force-pushed
the
feat/hologram-service
branch
from
dc51c9f to
ebd69f7
Compare
NonSwag
force-pushed
the
feat/hologram-service
branch
from
5b58ff6 to
63ef02f
Compare
- Bumped version to 1.2.0 - Refactored EconomyProvider to accept currency - Refactored EconomyProvider to return Component instead of String - Updated service-io dependency to v3
NonSwag
force-pushed
the
feat/hologram-service
branch
from
63ef02f to
6ce0c5e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Holograms is much more complex then the service API allows, some basic features aren't working even though technically possible.
Adding lines to holograms is not possible and requires a refactor of the ServiceIO API.
Also pagination support is missing in ServiceIO.