Skip to content

sorts: make quick sort support comparable items - #15290

Open
Ashwin121425-R wants to merge 2 commits into
TheAlgorithms:masterfrom
Ashwin121425-R:fix/quick-sort-comparable-v2
Open

sorts: make quick sort support comparable items#15290
Ashwin121425-R wants to merge 2 commits into
TheAlgorithms:masterfrom
Ashwin121425-R:fix/quick-sort-comparable-v2

Conversation

@Ashwin121425-R

Copy link
Copy Markdown
Contributor

Describe your change

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues, then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".
    Part of sorts: make algorithms sort any comparable items, not just ints #15234

Summary

  • add a Comparable protocol and generic type hints to quick_sort
  • use less-than comparisons so quick_sort works with comparable item types
  • add doctests for strings, floats, and non-comparable mixed values

Tests

  • python -m doctest -v .\sorts\quick_sort.py
  • python -m pytest tests/test_sorts.py
  • python -m ruff check .\sorts\quick_sort.py

@algorithms-keeper algorithms-keeper Bot added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Sep 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant