Skip to content

sorts: make quick sort support comparable items - #15289

Closed
Ashwin121425-R wants to merge 1 commit into
TheAlgorithms:masterfrom
Ashwin121425-R:fix/quick-sort-comparable
Closed

sorts: make quick sort support comparable items#15289
Ashwin121425-R wants to merge 1 commit into
TheAlgorithms:masterfrom
Ashwin121425-R:fix/quick-sort-comparable

Conversation

@Ashwin121425-R

Copy link
Copy Markdown
Contributor

Part of #15234

Summary

  • add a Comparable protocol and generic type hints to quick_sort
  • use less-than comparisons so quick_sort works with comparable item types
  • add doctests for strings, floats, and non-comparable mixed values

Tests

  • python -m doctest -v .\sorts\quick_sort.py
  • python -m pytest tests/test_sorts.py
  • python -m ruff check .\sorts\quick_sort.py

@algorithms-keeper algorithms-keeper Bot added the awaiting reviews This PR is ready to be reviewed label Sep 12, 2026
@algorithms-keeper

Copy link
Copy Markdown

Closing this pull request as invalid

@Ashwin121425-R, this pull request is being closed as none of the checkboxes have been marked. It is important that you go through the checklist and mark the ones relevant to this pull request. Please read the Contributing guidelines.

If you're facing any problem on how to mark a checkbox, please read the following instructions:

  • Read a point one at a time and think if it is relevant to the pull request or not.
  • If it is, then mark it by putting a x between the square bracket like so: [x]

NOTE: Only [x] is supported so if you have put any other letter or symbol between the brackets, that will be marked as invalid. If that is the case then please open a new pull request with the appropriate changes.

@algorithms-keeper algorithms-keeper Bot removed the awaiting reviews This PR is ready to be reviewed label Sep 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant