Skip to content

borked the logic on stop if nots in previous PR #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tomjemmett merged 2 commits into from
May 13, 2026
Merged

borked the logic on stop if nots in previous PR #118

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cabefea
borked the logic on stop if nots in previous PR
tomjemmett May 13, 2026
9e56203
improves logic
tomjemmett May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions R/read_azure_table.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,23 +26,23 @@ read_azure_table <- function(

if (!is.null(filter)) {
stopifnot(
is.character(filter) = "filter must be a character string",
length(filter) == 1 = "filter must be a single string"
"filter must be a character string" = is.character(filter),
"filter must be a single string" = length(filter) == 1
)
base_req <- httr2::req_url_query(base_req, `$filter` = filter)
}
if (!is.null(select)) {
stopifnot(
is.character(select) = "select must be a character string",
length(select) == 1 = "select must be a single string"
"select must be a character string" = is.character(select),
"select must be a single string" = length(select) == 1
)
base_req <- httr2::req_url_query(base_req, `$select` = select)
}
if (!is.null(top)) {
stopifnot(
is.numeric(top) = "top must be numeric",
length(top) == 1 = "top must be a single number",
top > 0 = "top must be a positive number"
"top must be numeric" = is.numeric(top),
"top must be a single number" = length(top) == 1,
"top must be a positive number" = top > 0
Comment thread
tomjemmett marked this conversation as resolved.
)
base_req <- httr2::req_url_query(base_req, `$top` = top)
}
Expand Down
Loading