feat(): grid labels#199
Conversation
ce6543d to
973161f
Compare
973161f to
dd23b4f
Compare
ShaMan123
left a comment
There was a problem hiding this comment.
Ready for review.
How do I test using packages/fragments/src/Importers/IfcImporter/test.ts?
There was a problem hiding this comment.
I think we should run prettier on the entire repo to it cleanup and include organizing imports.
We should also add .vscode/settings.json to cover organizing imports.
If you are troubled by the noise in the diff I will revert and cleanup.
| * after the swap. | ||
| */ | ||
| setGridMaterial(material: THREE.LineDashedMaterial) { | ||
| setGridMaterial(material: THREE.LineBasicMaterial) { |
There was a problem hiding this comment.
What do you think about this?
There was a problem hiding this comment.
Perhaps I should add that the default is a dash line material
|
@agviegas I changed the grid's tree, so this might be breaking. Now the tagged |
Description
Add built in grid labels that are opt in #192
grid.labels.mov
Additional context
Perhaps I should expose a method to change grid label offset directly
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following:
feat(examples): add hello-world example).fixes #123).