Skip to content

feat(): grid labels#199

Open
ShaMan123 wants to merge 7 commits intoThatOpen:mainfrom
ShaMan123:feat/grid-labels
Open

feat(): grid labels#199
ShaMan123 wants to merge 7 commits intoThatOpen:mainfrom
ShaMan123:feat/grid-labels

Conversation

@ShaMan123
Copy link
Copy Markdown
Contributor

@ShaMan123 ShaMan123 commented May 4, 2026

Description

Add built in grid labels that are opt in #192

model.getGrids({ labels: { show: true, font } });
grid.labels.mov

Additional context

Perhaps I should expose a method to change grid label offset directly


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following:

  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Follow the Conventional Commits v1.0.0 standard for PR naming (e.g. feat(examples): add hello-world example).
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@ShaMan123 ShaMan123 force-pushed the feat/grid-labels branch 2 times, most recently from ce6543d to 973161f Compare May 4, 2026 06:27
@ShaMan123 ShaMan123 force-pushed the feat/grid-labels branch from 973161f to dd23b4f Compare May 4, 2026 06:34
Copy link
Copy Markdown
Contributor Author

@ShaMan123 ShaMan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for review.
How do I test using packages/fragments/src/Importers/IfcImporter/test.ts?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should run prettier on the entire repo to it cleanup and include organizing imports.
We should also add .vscode/settings.json to cover organizing imports.
If you are troubled by the noise in the diff I will revert and cleanup.

* after the swap.
*/
setGridMaterial(material: THREE.LineDashedMaterial) {
setGridMaterial(material: THREE.LineBasicMaterial) {
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about this?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps I should add that the default is a dash line material

@ShaMan123
Copy link
Copy Markdown
Contributor Author

@agviegas I changed the grid's tree, so this might be breaking. Now the tagged userData.kind === "axis" is the group containing the line. What do you think? Should I mark this as breaking? Should I change the tagging to avoid breaking?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant